Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase the number of UT objects allowed to support > 127 #1074

Closed
skliper opened this issue Jun 11, 2021 · 0 comments · Fixed by #1075 or #1076
Closed

Increase the number of UT objects allowed to support > 127 #1074

skliper opened this issue Jun 11, 2021 · 0 comments · Fixed by #1075 or #1076
Labels
unit-test Tickets related to the OSAL unit testing (functional and/or coverage)
Milestone
Caelum

Comments

@skliper
Copy link
Contributor

skliper commented Jun 11, 2021

Is your feature request related to a problem? Please describe.
Right now the 128th object fails on creation (even though the UT code says 128 are supported):

osal/src/ut-stubs/utstub-helpers.h

Lines 57 to 67 in c540688

/*
* Size of the bitmask for the OSAL fake object ID validity table
* Set this according to the highest anticipated number of OSAL objects
* simultaneously created by any given test case (it is reset when the
* test is reset).
*
* Keep as a power of two, and actual number of bits is 8x this value
* (Default value of 16 allows for up to 128 objects to be created in
* a single test case, far more than anything I've seen yet)
*/
#define OSAL_MAX_VALID_PER_TYPE 16

Describe the solution you'd like
Bump to 32, since 128 isn't unreasonable on a large system.

Describe alternatives you've considered
None

Additional context
The use case was for pipes, they hit the 64 limit and doubled, then encountered UT errors.

Requester Info
Jacob Hageman - NASA/GSFC, ping @excaliburtb
@skliper skliper added the unit-test Tickets related to the OSAL unit testing (functional and/or coverage) label Jun 11, 2021
@skliper skliper added this to the 6.0.0 milestone Jun 11, 2021
skliper added a commit to skliper/osal that referenced this issue Jun 11, 2021
@skliper
Fix nasa#1074, Increase UT object limit for testing
0a6389b
@skliper skliper mentioned this issue Jun 11, 2021
Merged
astrogeco added a commit that referenced this issue Jun 15, 2021
@astrogeco
Merge pull request #1075 from skliper/fix1074_ut_object_limit
2587bec 
Fix #1074, Increase UT object limit for testing
@astrogeco astrogeco mentioned this issue Jun 15, 2021
Merged
skliper added a commit to skliper/osal that referenced this issue Jun 16, 2021
@skliper
Fix nasa#1074, Increase UT object limit for testing
563d6b5
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
@skliper
Fix nasa#1074, Refactor CFE_TIME_RegisterSynchCallback
ad74393 
- One return point
- Eliminates "possible uninitialized variable" static
analysis warning
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
@astrogeco
Merge pull request nasa#1075 from skliper/fix1074-multiple_returns
c9f9d42 
Fix nasa#1074, Refactor CFE_TIME_RegisterSynchCallback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
unit-test Tickets related to the OSAL unit testing (functional and/or coverage)
Projects
None yet
Milestone
Caelum
1 participant
@skliper