Check Return Value for setsockopt

[ArielSAdamsNASA]

Describe the bug
Calling setsockopt(impl->fd, 1, 2, &os_flags, 4U) without checking return value. This library function may fail and return an error code.

Expected behavior
Check return value for setsockopt

Code snips

osal/src/os/portable/os-impl-bsd-sockets.c

Line 199 in 42af0f7

setsockopt(impl->fd, SOL_SOCKET, SO_REUSEADDR, &os_flags, sizeof(os_flags));

System observed on:
Coverity: https://scan.coverity.com/projects/arielsadamsnasa-cfs-jsf-rules?tab=overview

Additional context
Possible solution

if (setsockopt(impl->fd, SOL_SOCKET, SO_REUSEADDR, &os_flags, sizeof(os_flags)) == 0)
{
    setsockopt(impl->fd, SOL_SOCKET, SO_REUSEADDR, &os_flags, sizeof(os_flags));
}

Reporter Info
Ariel Adams, ASRC Federal

[himanshu007-creator]

hi i would like to work on this issue

[ArielSAdamsNASA]

@himanshu007-creator Thank you for the participation! I assigned you to this issue.

[skliper]

@ArielSAdamsNASA @himanshu007-creator - I'm not sure this solution solves an actual issue. This suggestion just does the same call again if the first fails which doesn't seem to be any better (odds are it'll just fail again). Although it is a static analysis warning, it's already documented (in comments) that if the call fails there isn't a need to take any further action. I'd recommend just closing this issue and the related pull request.

[himanshu007-creator]

Got it