OS_API_Init() does not correct cleanup resources on error

[skliper]

OS_API_Init initializes several OS primitives but is made with a pattern of exiting as soon as any initialization fails without cleaning up previous successful initializations. For example:

OS_task_table_sem = semMCreate(SEM_Q_PRIORITY | SEM_INVERSION_SAFE );
if ( OS_task_table_sem == NULL )
{
return(OS_ERROR);
}

OS_queue_table_sem = semMCreate(SEM_Q_PRIORITY | SEM_INVERSION_SAFE );
if ( OS_queue_table_sem == NULL )
{
return(OS_ERROR);
}

If OS_task_table_sem successfully initializes, but OS_queue_table_sem does not, then OS_task_table_sem will become a leaked resource.

[skliper]

Imported from trac issue 148. Created by sseeger on 2016-01-10T01:01:51, last modified: 2019-08-14T14:11:46

[skliper]

Trac comment by sseeger on 2016-01-11 13:49:13:

This ticket is relevant to at least the vxWorks implementation

[skliper]

Now calling CFE_PSP_Panic for any OS_API_Init failure, which is documented as "irrecoverable". No clean-up is really applicable.