Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Functional Timer Test Hard Codes Configuration Value #196

Closed
skliper opened this issue Sep 30, 2019 · 3 comments · Fixed by #490 or #529
Closed

Functional Timer Test Hard Codes Configuration Value #196

skliper opened this issue Sep 30, 2019 · 3 comments · Fixed by #490 or #529
Labels
enhancement unit-test Tickets related to the OSAL unit testing (functional and/or coverage)
Milestone
Bootes

Comments

@skliper
Copy link
Contributor

skliper commented Sep 30, 2019

The functional timer test (/src/tests/timer-test/timer-test.c) hard codes the number of timers to 4, which may be higher than the OS_MAX_TIMERS configuration set in osconfig.h.

It is recommended to update the test to use the OS_MAX_TIMERS configuration macro or add protection with an #if guard.
@skliper skliper added this to the osal-5.0.1 milestone Sep 30, 2019
@skliper skliper self-assigned this Sep 30, 2019
@skliper skliper added the bug label Sep 30, 2019
@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Imported from trac issue 173. Created by sstrege on 2016-08-03T17:27:41, last modified: 2019-08-14T14:11:46

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by jhageman on 2019-07-03 13:34:40:

Moved open 4.2.2 tickets to 4.3.1

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by jhageman on 2019-07-26 15:13:16:

Milestone renamed

@skliper skliper modified the milestones: osal-5.0.1, osal-5.1.0 Sep 30, 2019
@skliper skliper removed their assignment Sep 30, 2019
@skliper skliper added enhancement and removed bug labels Oct 22, 2019
@skliper skliper removed this from the 5.1.0 milestone Oct 22, 2019
@skliper skliper added this to the 5.1.0 milestone Nov 1, 2019
@skliper skliper added the unit-test Tickets related to the OSAL unit testing (functional and/or coverage) label Apr 10, 2020
yammajamma added a commit to yammajamma/osal that referenced this issue Jun 4, 2020
@yammajamma
Fix nasa#196, Fix timer-test to be able to use OS_MAX_TIMERS value
4dfcb3e
@yammajamma yammajamma mentioned this issue Jun 4, 2020
Merged
yammajamma added a commit to yammajamma/osal that referenced this issue Jun 5, 2020
@yammajamma
Fix nasa#196, removed redefinition of a variables as requested
80bca3f
astrogeco pushed a commit that referenced this issue Jul 1, 2020
@yammajamma
Fix #196, Fix timer-test to be able to use OS_MAX_TIMERS value (#490)
83a3c42 
* Fix #196, Fix timer-test to be able to use OS_MAX_TIMERS value

* Fix #196, removed redefinition of a variables as requested
@astrogeco astrogeco mentioned this issue Jul 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement unit-test Tickets related to the OSAL unit testing (functional and/or coverage)
Projects
None yet
Milestone
Bootes
1 participant
@skliper