Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OS_SelectSingle(fd, &SelectFlags, timeout) users require OS_STREAM_STATE_READABLE/OS_STREAM_STATE_WRITABLE #392

Closed
CDKnightNASA opened this issue Mar 26, 2020 · 0 comments · Fixed by #409 or #433
Closed

OS_SelectSingle(fd, &SelectFlags, timeout) users require OS_STREAM_STATE_READABLE/OS_STREAM_STATE_WRITABLE #392

CDKnightNASA opened this issue Mar 26, 2020 · 0 comments · Fixed by #409 or #433
Assignees
@CDKnightNASA
Labels
bug
Milestone
Bootes

Comments

@CDKnightNASA
Copy link
Contributor

Describe the bug
In order to use OS_SelectSingle() a user needs access to the #defines for OS_STREAM_STATE_READABLE and OS_STREAM_STATE_WRITABLE but they are contained in osal/src/os/shared/os-impl.h not in osal/src/os/inc/...

To Reproduce
Try to use the OS_SelectSingle API :)

Expected behavior
These #defines need to be moved to osal/src/os/inc

Reporter Info
Christopher.D.Knight@nasa.gov
@CDKnightNASA CDKnightNASA self-assigned this Mar 26, 2020
CDKnightNASA added a commit to CDKnightNASA/osal that referenced this issue Mar 26, 2020
@CDKnightNASA
fix for nasa#392 - moves OS_STREAM_STATE... to os/inc/osapi-os-core.h…
f1115fc 
… as it's needed by OS_SelectSingle()
@CDKnightNASA CDKnightNASA mentioned this issue Mar 26, 2020
Closed
@skliper skliper added the bug label Mar 26, 2020
CDKnightNASA added a commit to CDKnightNASA/osal that referenced this issue Mar 27, 2020
@CDKnightNASA
fix for nasa#392 - moves OS_STREAM_STATE... to os/inc/osapi-os-core.h…
a1e7e03 
… as it's needed by OS_SelectSingle()
CDKnightNASA added a commit to CDKnightNASA/osal that referenced this issue Mar 27, 2020
@CDKnightNASA
fix for nasa#392 - exposing OS_STREAM_STATE_* in public .h files for …
f0fae6a 
…OS_SelectSingle()
@CDKnightNASA CDKnightNASA added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Mar 31, 2020
@astrogeco astrogeco linked a pull request Apr 1, 2020 that will close this issue
Fix #392, Make OS_STREAM_STATE available with APIs #393
Closed
@astrogeco astrogeco added CCB - 20200401 and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Apr 1, 2020
@CDKnightNASA CDKnightNASA mentioned this issue Apr 3, 2020
Closed
CDKnightNASA added a commit to CDKnightNASA/osal that referenced this issue Apr 7, 2020
@CDKnightNASA
fix nasa#377, fix nasa#390, fix nasa#392 - osal select API unit tests…
e7b58e7 
… and fixes
@CDKnightNASA CDKnightNASA mentioned this issue Apr 7, 2020
Merged
astrogeco added a commit that referenced this issue Apr 21, 2020
@astrogeco
Merge pull request #409 from CDKnightNASA/fix-377-select_ut
27dc32f 
Fix #390 and #392, osal select API unit tests and fixes
@astrogeco astrogeco mentioned this issue Apr 27, 2020
Merged
@astrogeco astrogeco linked a pull request Apr 27, 2020 that will close this issue
Integration Candidate: 2020-04-15 #433
Merged
astrogeco pushed a commit that referenced this issue May 1, 2020
@CDKnightNASA
fix #377, fix #390, fix #392 - osal select API unit tests and fixes
e4b3789
@skliper skliper added this to the 5.1.0 milestone Jun 18, 2020
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
@avan989 @skliper
Fix nasa#392, cpp check warning
002e834
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
@skliper
20191106/13: Merge nasa#387 nasa#390 nasa#391 nasa#393 nasa#395 nasa#400
9aedaab 


Fixes nasa#379, Fixes nasa#380, Fixes nasa#383, Fixes nasa#384,
Fixes nasa#385, Fixes nasa#392
Code reviewed and approved at 20191106 and 20191113 CB
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CDKnightNASA CDKnightNASA

Labels
bug
Projects
None yet
Milestone
Bootes
3 participants
@CDKnightNASA @skliper @astrogeco