Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use UT_Assert Macros in tests/unit-test-coverage/unit-tests #484

Open
astrogeco opened this issue May 27, 2020 · 2 comments
Open

Use UT_Assert Macros in tests/unit-test-coverage/unit-tests #484

astrogeco opened this issue May 27, 2020 · 2 comments
Labels
unit-test Tickets related to the OSAL unit testing (functional and/or coverage)

Comments

@astrogeco
Copy link
Contributor

astrogeco commented May 27, 2020

Is your feature request related to a problem? Please describe.
Upgrade tests in time-base-api-test.c to use new macros in
https://github.com/nasa/osal/blob/master/src/unit-tests/inc/ut_os_support.h

Really in general could be used all over for consistency.

Note there's typos in the use of UTAssert_True, example:

expected = OS_FS_ERR_PATH_INVALID;
actual = OS_TranslatePath("/test/myfile.txt", translated_path);
UtAssert_True(actual == expected, "OS_TranslatePath() (%ld) == OS_SUCCESS", (long)actual);

Additional context
See #481

Requester Info
Gerardo Cruz-Ortiz, NASA-GSFC

@astrogeco
Copy link
Contributor Author

@CDKnightNASA and @yammajamma check this out

@CDKnightNASA
Copy link
Contributor

@CDKnightNASA and @yammajamma check this out

yup ;)

@skliper skliper added the unit-test Tickets related to the OSAL unit testing (functional and/or coverage) label Dec 9, 2020
@skliper skliper changed the title Use UT_Assert Macros in time-base-api-test.c Use UT_Assert Macros in tests/unit-test-coverage/unit-tests Dec 9, 2020
@skliper skliper added this to the 6.0.0 milestone May 10, 2021
@skliper skliper removed this from the 6.0.0 milestone Jun 3, 2021
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
unit-test Tickets related to the OSAL unit testing (functional and/or coverage)
Projects
None yet
Development

No branches or pull requests

3 participants