-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1025, Add Coding Standard Rules in CodeQL #1034
Closed
ArielSAdamsNASA
wants to merge
17
commits into
nasa:main
from
ArielSAdamsNASA:fix-1025-coding-standards-codeql
Closed
Fix #1025, Add Coding Standard Rules in CodeQL #1034
ArielSAdamsNASA
wants to merge
17
commits into
nasa:main
from
ArielSAdamsNASA:fix-1025-coding-standards-codeql
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@ArielSAdamsNASA Could you document the reason for closure and add the appropriate tag (invalid, wontfix, duplicate, etc)? |
Closed due to duplicate and newer PR. |
Duplicate of #1042 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #1025
Added the duplicate jobs action to avoid duplicate jobs from running. Added a separate job for coding standard queries. Created two configuration files, one for default queries and security queries and another for jpl rules.
Testing performed
Testing done on forked repository, ArielSAdamsNASA/cFE.
Jobs were failing when the entire path of the configuration file were not used. Have to use nasa/cFE/.github/codeql/config-name@branch-name. The branch must be included in the path.
The CodeQL analysis workflow will fail for this PR since it is calling for a configuration file in main the main branch. It will not work until the configuration files are merged into main.
To prove that this workflow will work, I tested a workflow on a forked repository. In the screenshot, the configuration path is changed to the forked repo and tested branch and successfully runs both CodeQL jobs.
Expected behavior changes
There should be one job for security queries and one job for JPL and MISRA queries.
Third party code
Skip duplicate workflows license: https://github.com/fkirc/skip-duplicate-actions/blob/master/LICENSE
CodeQL license: https://github.com/github/codeql-action/blob/main/LICENSE
Contributor Info - All information REQUIRED for consideration of pull request
Ariel Adams, ASRC Federal