Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial #1225, Update cFS-build CodeQL reusable worfklow target #1230

Merged
merged 1 commit into from
Mar 16, 2022

Conversation

chillfig
Copy link
Contributor

@chillfig chillfig commented Mar 11, 2022

Describe the contribution
Partial #1225
changes tests input to boolean, changes source input for uses,
component-path to osal, changes to tests to test, removes makeprep input

Testing performed
github actions check: https://github.com/chillfig/osal/actions/runs/1993521933

Expected behavior changes
Passing workflow

System(s) tested on
Ubuntu 18.4

Contributor Info - All information REQUIRED for consideration of pull request
Justin Figueroa, ASRC Federal

@astrogeco
Copy link
Contributor

@chillfig can you change the title of the PR and amend the commit so it reads "Fix #1225, Update cFS-build CodeQL reusable workflow target"?

@chillfig chillfig force-pushed the codeql_workflow_fix branch from ca0d090 to c4865bf Compare March 14, 2022 16:30
@astrogeco
Copy link
Contributor

My bad, I should have typed "partial" instead of "fix" commit message should look like:

Partial #1225, Update cFS-build CodeQL reusable worfklow target

Also you'll have to squash the commits like we practiced on Friday using git rebase

@astrogeco astrogeco added CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) continuous-integration and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Mar 16, 2022
@chillfig chillfig force-pushed the codeql_workflow_fix branch from 158f5fa to 349ce0e Compare March 16, 2022 15:04
@chillfig chillfig changed the title Partial #1225, Testing fix to codeql build Partial #1225, Update cFS-build CodeQL reusable worfklow target Mar 16, 2022
@astrogeco
Copy link
Contributor

Looks like an extra file sneaked through. Run git reset main then commit only codeql-cfe-build.yml.

Screen Shot 2022-03-16 at 11 32 20 AM

changes tests input to boolean, changes source input for uses, adds new lines
component-path to osal, changes tests to test, removes makeprep input
@chillfig chillfig force-pushed the codeql_workflow_fix branch from 349ce0e to a3065d9 Compare March 16, 2022 16:02
@astrogeco
Copy link
Contributor

CCB:2022-03-16 APPROVED

@astrogeco astrogeco added the CCB:Approved Indicates code review and approval by community CCB label Mar 16, 2022
astrogeco added a commit to nasa/cFS that referenced this pull request Mar 16, 2022
@astrogeco astrogeco merged commit da2a61d into nasa:main Mar 16, 2022
@skliper skliper added this to the Draco milestone Mar 25, 2022
jphickey pushed a commit to jphickey/osal that referenced this pull request Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB continuous-integration draco-rc1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants