Fix #1417, Fix #1418, Fix workflow bug and enforce updating of coverage minimums #1419
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
env.run_lcov == 'TRUE'
, which is what triggers the 'Check Coverage' step to run)Testing performed
Tested all variations of coverage thresholds (above, below, split between functions/lines/branches etc.) to confirm expected behavior.
New checks:
![Screenshot 2023-09-23 20 32 15](https://private-user-images.githubusercontent.com/9024662/270101934-441bea23-01c6-4f14-9713-04c319f0df0b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2NzM1MjAsIm5iZiI6MTczOTY3MzIyMCwicGF0aCI6Ii85MDI0NjYyLzI3MDEwMTkzNC00NDFiZWEyMy0wMWM2LTRmMTQtOTcxMy0wNGMzMTlmMGRmMGIucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTZUMDIzMzQwWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZWYyZDk1MGI3OTEzZjFjMjYzOWUwNzliMTRjY2MxM2JmYTFmZWNmYWZjYWE5NmUzMjAwOGM2NWI1YWEzNTJlYyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.6rLX_wFW-pfrTqBPkhn-8qxdLVloJCEKhueYwkkI6R4)
Expected behavior changes
Any PR that improves coverage will cause the workflow to fail now unless the
allowed_ncov_lines
,allowed_ncov_branches
and/orallowed_ncov_functions
variables are updated as part of the same PR.System(s) tested on
Debian GNU/Linux 11 (bullseye)
Current main branch of cFS bundle.
Contributor Info
Avi Weiss @thnkslprpt