Fix #287: cppcheck warnings #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace use of (1<<31) and (INT_MAX) with (UINT32_MAX/2) which should squelch the cppcheck warnings about the left shift as well as being more correct (the values in question are uint32's, not int's). Also address two false positives about a return value being unassigned, by simply initializing the value to be 0.
skliper
approved these changes
Nov 18, 2019
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Removes untraced capabilities to decompress libraries or apps on load. For non-startup apps, FS can be used. For startup, recommendation is to compress/decompress as part of boot/startup vs individual applications/libs at load. Also fixes nasa#291, by deprecating decompress it can be moved to the FS app. Also makes nasa#135 N/A, static code analysis issues in decompress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Replace use of
1<<31andINT_MAXwithUINT32_MAX/2which shouldsquelch the cppcheck warnings about the left shift as well as being
more correct (the values in question are uint32's, not int's).
Also address two false positives about a return value being unassigned,
by simply initializing the value to be 0.
Fixes issue #287
Testing performed
Build coverage test and ensure all tests passing and line coverage is unaffected
Build and run CFE and confirm no effect.
Ran cppcheck and confirmed that warnings are gone.
Expected behavior changes
No impact to behavior.
System(s) tested on:
Ubuntu 18.04 LTS, 64 bit.
Contributor Info
Joseph Hickey, Vantage Systems, Inc.
Community contributors
You must attach a signed CLA (required for acceptance) or reference one already submitted