Integration Candidate: Fast Track #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use separate source files and CMake-based source selection to configure OSAL features, rather than using the C preprocessor. All implementation units now provide a separate header file for each functional group/subsystem. This commit covers the OSAL main FSW code and particularly the "portable" implementation blocks to follow this model. Includes minor updates to UT stubs due to header file changes.
Use separate source files and CMake-based source selection to configure OSAL features, rather than using the C preprocessor. This commit covers the OSAL coverage test. This had been using inclusion of a C file to allow access to static functions/variables. This updates all UT code to correspond with the FSW code changes. All "static" helper functions become non-static so unit test can invoke directly. Prototype is in a private header, so the functions are still not exposed in the API.
Permissive mode is required for testing on POSIX when running as a normal (non-root) user.
Fix #285, Refactor OSAL to avoid inclusion of C files
The "include()" cmake function only read the first file when passed a list. Adding a foreach loop supports allowing a list of files which is useful for adding and override/addendum file to a base config.
Definitions within osconfig.h are referenced by doxygen in other source code files, so this should also include doxygen-formatted descriptions of each macro defined by this template file.
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
issue nasa#443, update toolchain-ppc-vxworks6.9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fixes #285
Testing performed
See #443
Bundle CI - https://github.com/nasa/cFS/pull/78/checks?check_run_id=644721591
Expected behavior changes
Changes build system considerably:
System(s) tested on
See PR
Bundle CI - Ubuntu:Bionic
Additional context
Part of nasa/cFS#78
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.