Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #494, add missing stub functions for OSAL API #497

Merged

Conversation

jphickey
Copy link
Contributor

Describe the contribution
Did a quick scrub for public OSAL APIs defined in libosal.a but not defined in stub library.

Added stub functions for:

OS_TaskFindIdBySystemData()
OS_FileSysAddFixedMap()
OS_TimedRead()
OS_TimedWrite()
OS_FileSysAddFixedMap()

Required for testing other modules that use these functions. Also correct a name mismatch issue in OS_TaskGetInfo().

Fixes #494

Testing performed
Build and run all unit tests.

Expected behavior changes
No change to behavior or FSW. Just adds stubs for future use.

System(s) tested on
Ubuntu 20.04

Additional context
These were not actively used anywhere yet (otherwise would be a link failure) but likely to become an issue as PSP coverage tests are implemented.

Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

Added sub functions for:
  OS_TaskFindIdBySystemData
  OS_FileSysAddFixedMap
  OS_TimedRead
  OS_TimedWrite
  OS_FileSysAddFixedMap

Required for testing other modules that use these functions.
Also correct a name mismatch issue in OS_TaskGetInfo.
@jphickey jphickey added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Jun 10, 2020
@astrogeco astrogeco added CCB-20200610 CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Jun 10, 2020
@jphickey
Copy link
Contributor Author

Note - commit b6b1ad8 corrects a copy/paste issue with task_id output of OS_TaskFindIdBySystemData stub - should be filling the buffer not a pointer to buffer.

@astrogeco astrogeco changed the base branch from master to integration-candidate June 16, 2020 20:28
@astrogeco astrogeco merged commit 4efd29f into nasa:integration-candidate Jun 17, 2020
@jphickey jphickey deleted the fix-494-add-fixedmap-stub branch June 19, 2020 16:13
@skliper skliper added this to the 5.1.0 milestone Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing stub function for OS_FileSysAddFixedMap
3 participants