Fast Track for Integration Candidate 2020-06-10 #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the following macros for UT assert: UtAssert_INT32_EQ - check equality as 32 bit signed int UtAssert_UINT32_EQ - check equality as 32 bit unsigned int UtAssert_NOT_NULL - check pointer not null UtAssert_NULL - check pointer is null UtAssert_NONZERO - check integer is nonzero UtAssert_ZERO - check integer is zero UtAssert_STUB_COUNT - check stub count These are all just wrappers around UtAssert_True for commonly-used asserts. The description message is auto generated so it is consistent.
Some systems may not provide this type. Using "unsigned long" instead should be sufficient.
Fix #502, Add extra assert macros
Fix #509, Remove uintmax_t usage
astrogeco
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fast Tracked Changes to Integration Candidate 2020-06-10
Fix #509
Fix #502
Testing performed
Bundle CI - https://github.com/nasa/cFS/pull/102/checks
Expected behavior changes
PR #503 - Added the following wrappers macros around
UtAssert_Truefor commonly-used asserts:UtAssert_INT32_EQ- check equality as 32 bit signed intUtAssert_UINT32_EQ- check equality as 32 bit unsigned intUtAssert_NOT_NULL- check pointer not nullUtAssert_NULL- check pointer is nullUtAssert_NONZERO- check integer is nonzeroUtAssert_ZERO- check integer is zeroUtAssert_STUB_COUNT- check stub countPR #510 - Using
unsigned longinstead ofuintmax_tto fix support for VxWorksSystem(s) tested on
Ubuntu:Bionic
Additional context
Part of nasa/cFS#102
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.