Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #561, remove all deprecated code #562

Merged

Conversation

jphickey
Copy link
Contributor

Describe the contribution
In the next major OSAL release, this code will be no longer supported at all. It should be removed early in the cycle
to avoid needing to maintain this compatibility code.

Fixes #561

Testing performed
Build on native, RTEMS, and VxWorks and Confirm no issues/errors.
Run all unit tests.
Sanity check CFE core.

Expected behavior changes
All old compatibility code is removed.

System(s) tested on
Ubuntu 20.04
RTEMS 4.11.3

Additional context
This code was already conditional on the OSAL_OMIT_DEPRECATED flag and as such the CCB has already tested/verified running the code in this configuration as part of CI scripts.

After this change, the build should be equivalent to the result of building with OMIT_DEPRECATED=true.

Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

In the next major OSAL release, this code will be no longer
supported at all.  It should be removed early in the cycle
to avoid needing to maintain this compatibility code.
@jphickey jphickey added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Aug 18, 2020
@astrogeco
Copy link
Contributor

astrogeco commented Aug 19, 2020

CCB 2020-08-19 APPROVED, Need more discussion about deprecation timeline.

@astrogeco
Copy link
Contributor

@jphickey can we do an intermediate commit to rename OSAL_OMIT_DEPRECATED to OSAL_OMIT_DEPRECATED_5_0 before removing stuff. That way we can have a slightly more readable history. Thoughts?

@skliper
Copy link
Contributor

skliper commented Aug 19, 2020

@astrogeco - I thought we approved this one? Further discussion required on the topic of removing elements deprecated this cycle before the release of Caelum.

@astrogeco
Copy link
Contributor

@astrogeco - I thought we approved this one? Further discussion required on the topic of removing elements deprecated this cycle before the release of Caelum.

Good point, I think that's what I was trying to say in my previous comment. Make sure there's nothing in the list that was deprecated for Caelum then remove anything that was deprecated for Bootes.

I'll edit the CCB comment to reflect approval status

@skliper skliper added this to the 6.0.0 milestone Aug 21, 2020
@astrogeco astrogeco removed the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Aug 26, 2020
@yammajamma yammajamma added IC-20200826 CCB:Approved Indicates code review and approval by community CCB labels Aug 27, 2020
@yammajamma yammajamma changed the base branch from main to integration-candidate August 27, 2020 17:19
@yammajamma yammajamma merged commit 881aa63 into nasa:integration-candidate Aug 27, 2020
@skliper skliper linked an issue Sep 21, 2020 that may be closed by this pull request
@jphickey jphickey deleted the fix-561-remove-deprecated branch December 3, 2020 17:26
jphickey pushed a commit to jphickey/osal that referenced this pull request Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB CCB:Splinter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove OSAL deprecated code for next release Scrub and remove depreciated elements
4 participants