-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #561, remove all deprecated code #562
Fix #561, remove all deprecated code #562
Conversation
In the next major OSAL release, this code will be no longer supported at all. It should be removed early in the cycle to avoid needing to maintain this compatibility code.
CCB 2020-08-19 APPROVED, Need more discussion about deprecation timeline. |
@jphickey can we do an intermediate commit to rename |
@astrogeco - I thought we approved this one? Further discussion required on the topic of removing elements deprecated this cycle before the release of Caelum. |
Good point, I think that's what I was trying to say in my previous comment. Make sure there's nothing in the list that was deprecated for Caelum then remove anything that was deprecated for Bootes. I'll edit the CCB comment to reflect approval status |
Fix nasa#561, Add branch coverage reporting
Describe the contribution
In the next major OSAL release, this code will be no longer supported at all. It should be removed early in the cycle
to avoid needing to maintain this compatibility code.
Fixes #561
Testing performed
Build on native, RTEMS, and VxWorks and Confirm no issues/errors.
Run all unit tests.
Sanity check CFE core.
Expected behavior changes
All old compatibility code is removed.
System(s) tested on
Ubuntu 20.04
RTEMS 4.11.3
Additional context
This code was already conditional on the
OSAL_OMIT_DEPRECATED
flag and as such the CCB has already tested/verified running the code in this configuration as part of CI scripts.After this change, the build should be equivalent to the result of building with
OMIT_DEPRECATED=true
.Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.