Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #445, add pointer parameter checks #715

Merged
merged 1 commit into from
Jan 13, 2021

Conversation

jphickey
Copy link
Contributor

Describe the contribution
Add OS_CHECK_POINTER macros to OS_ConvertToArrayIndex and OS_TimeBaseGetFreeRun.

Fixes #445

Testing performed
Run all unit tests

Expected behavior changes
None

System(s) tested on
Ubuntu 20.04

Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

Add OS_CHECK_POINTER macros to OS_ConvertToArrayIndex and
OS_TimeBaseGetFreeRun.
@jphickey jphickey added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Dec 29, 2020
@astrogeco astrogeco added CCB-20210106 and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Jan 6, 2021
@astrogeco
Copy link
Contributor

CCB 2021-01-06 APPROVED

@astrogeco astrogeco changed the base branch from main to integration-candidate January 13, 2021 02:56
@astrogeco astrogeco merged commit 4e16b38 into nasa:integration-candidate Jan 13, 2021
astrogeco added a commit to nasa/cFS that referenced this pull request Jan 13, 2021
@jphickey jphickey deleted the fix-445-param-checks branch January 27, 2021 14:09
@skliper skliper added this to the 6.0.0 milestone Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OS_ConvertToArrayIndex and OS_TimeBaseGetFreeRun SEGFAULT When Passed in a NULL Pointer
3 participants