Fix #777, Static allocation of DummyVec in OSC_INUM_TO_IVEC stub #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jphickey
approved these changes
Feb 10, 2021
jphickey
added a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Provides ability to load UT assert as a CFE app, and an example of using this to test some basic CFE ES functions.
jphickey
added a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Fix nasa#778, add cfe assert and example lib
jphickey
added a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Provides ability to load UT assert as a CFE app, and an example of using this to test some basic CFE ES functions. This introduces a separate library for the basic UT assert functions (cfe_assert) and an app that executes the test (cfe_testrunner) rather than combining these into a single module.
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Revert "Fix nasa#778, add cfe assert and example lib"
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Fix nasa#778, Add CFE_Assert library and test module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #777, declares DummyVec as static to avoid warning (and returning stack allocated memory) when returning VecTbl.
Testing performed
Build and execute unit tests, passed.
Expected behavior changes
Bug in stub fixed (could have been issues if return value used).
System(s) tested on
Additional context
CodeQL warning resolution
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC