Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #783, Initialize locals flagged in static analysis #784

Merged
merged 1 commit into from
Feb 12, 2021

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Feb 9, 2021

Describe the contribution
Fix #783, Simply adds initialization where flagged by static analysis as possibly uninitialized

Testing performed
Build and run unit tests

Expected behavior changes
No functional change to non-test code, avoids returning uninitialized values from stubs.

System(s) tested on

  • Hardware: cFS Dev Server
  • OS: Ubuntu 18.04
  • Versions: cFS Bundle main + this commit

Additional context
None

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added this to the 6.0.0 milestone Feb 9, 2021
@skliper skliper force-pushed the fix783-uninit_locals branch from f1dc67d to a1dd733 Compare February 9, 2021 21:46
@skliper skliper changed the title Fix #782, Initialize locals flagged in static analysis Fix #783, Initialize locals flagged in static analysis Feb 9, 2021
@skliper skliper force-pushed the fix783-uninit_locals branch from a1dd733 to b9a7697 Compare February 9, 2021 21:52
@astrogeco astrogeco changed the base branch from main to integration-candidate February 12, 2021 20:33
@astrogeco astrogeco merged commit eab4422 into nasa:integration-candidate Feb 12, 2021
@skliper skliper deleted the fix783-uninit_locals branch April 1, 2021 20:07
jphickey pushed a commit to jphickey/osal that referenced this pull request Aug 10, 2022
…_deprecated

fix nasa#759 - deprecates GetLastSenderId()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor to avoid possible uninitialized local variables
4 participants