Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #809, cast args to printf in queue-test #811

Merged

Conversation

jphickey
Copy link
Contributor

Describe the contribution

Using %u conversion requires an unsigned int arg, not uint32 (it matches on some platforms, not on others).

Fixes #809

Testing performed
Build and run tests on RTEMS 4.11.3.

Expected behavior changes
No more format mismatch warning/error.

System(s) tested on
RTEMS 4.11.3 QEMU target on Ubuntu 20.04 build host

Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

Using %u conversion requires unsigned int arg, not necessarily uint32
@jphickey jphickey added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Feb 12, 2021
@skliper skliper added this to the 6.0.0 milestone Feb 12, 2021
@skliper
Copy link
Contributor

skliper commented Feb 12, 2021

@astrogeco requesting fasttrack, broken.

@astrogeco
Copy link
Contributor

Random label question, would this fall under unit-test? What kind of tests do we have under the "tests" directory?

@skliper
Copy link
Contributor

skliper commented Feb 12, 2021

@astrogeco I'd call it unit-test, for me that covers every kind of testing (not production code)

@astrogeco
Copy link
Contributor

@astrogeco I'd call it unit-test, for me that covers every kind of testing (not production code)

Should we then rename the label to tests or something like that with the possibility of expanding it to tests:unit or tests:functional etc? Yes, I love labels...

@astrogeco astrogeco changed the base branch from main to integration-candidate February 12, 2021 21:29
@astrogeco astrogeco merged commit 9888e3f into nasa:integration-candidate Feb 12, 2021
@skliper
Copy link
Contributor

skliper commented Feb 12, 2021

All I use it for is to filter if it's production code or not, I don't have an opinion over any smaller groups

@astrogeco astrogeco added CCB:2021-02-17 and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Feb 17, 2021
@jphickey jphickey deleted the fix-809-printf-format branch April 28, 2021 18:58
jphickey pushed a commit to jphickey/osal that referenced this pull request Aug 10, 2022
jphickey pushed a commit to jphickey/osal that referenced this pull request Aug 10, 2022
jphickey pushed a commit to jphickey/osal that referenced this pull request Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RTEMS build broken due to format mismatch (again)
4 participants