Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using aux_source_directory #41

Closed
jphickey opened this issue Feb 11, 2020 · 0 comments · Fixed by #42
Closed

Avoid using aux_source_directory #41

jphickey opened this issue Feb 11, 2020 · 0 comments · Fixed by #42
Labels
bug Something isn't working build-system
Milestone

Comments

@jphickey
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The example build script should not use aux_source_directory() as it is not well defined/controlled behavior - it depends on files that existed at the time "prep" was run.

Describe the solution you'd like
CMakeLists.txt should list the app source files explicitly. This is recommended CMake practice for most normal build cases.

Additional context
This is a prime example of why aux_source_directory() is discouraged, because in this case it incorrectly pulled in the "sample_table.c" source file into the app binary. This is incorrect; the table file is built separately by the table generator script.

Requester Info
Joseph Hickey, Vantage Systems, Inc.

astrogeco added a commit that referenced this issue Mar 23, 2020
Fix #41, Do not use aux_source_directory in sample build script
@astrogeco astrogeco added bug Something isn't working build-system labels Oct 1, 2020
@astrogeco astrogeco added this to the 1.2.0 milestone Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working build-system
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants