Fix #9, Unit test for SAMPLE lib #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jphickey
force-pushed
the
fix-9-sample-lib-unit-test
branch
from
a00bf18 to
09d5ff7
Compare
|
NOTE: force-pushed to fix a comment. No substantive change. |
skliper
previously requested changes
Dec 17, 2019
|
CCB 20200122 - Discussed, scoping is lower priority than standard compliance, but preference is to test via available mechanisms (not accessing internals). |
astrogeco
added
CCB:Ready
astrogeco
removed
the
CCB:Ignore
jphickey
force-pushed
the
fix-9-sample-lib-unit-test
branch
from
09d5ff7 to
9d42bf2
Compare
Implements a coverage test for sample_lib code as well as a stub library to facilitate unit test of external code that calls functions within sample_lib.
jphickey
force-pushed
the
fix-9-sample-lib-unit-test
branch
from
9d42bf2 to
b734bca
Compare
|
Latest push rebases to "master" and removes wrappers used to access the static fields. |
jphickey
added
CCB:Ready
|
CCB 20200318 - Check if there's any 6.6->6.7 changes. Otherwise Approved. |
astrogeco
added
CCB - 20200318
and removed
CCB:Ready
astrogeco
added
CCB:Approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fixes #9
Implements a coverage test for sample_lib code as well as a stub library to facilitate unit test of external code that calls functions within sample_lib.
Testing performed
Build with SIMULATION=native ENABLE_UNIT_TESTS=TRUE
Confirm normal CFE operation is unaffected
Confirm unit tests all pass, including new test of "sample_lib"
Confirm "lcov" report now includes sample_lib, and coverage is 100%
Expected behavior changes
This adds a new test for "sample_lib" which is part of the make test target, and the line coverage reports now include sample_lib.
System(s) tested on:
Ubuntu 18.04 LTS 64-bit
Additional context
The coverage test cases are written assuming that previous pull request #10 is already merged. That is, they exercise/test the logic that was added in this. Therefore this commit is a child of the commit for the previous pull request.
Contributor Info
Joseph Hickey, Vantage Systems, Inc.
Community contributors
You must attach a signed CLA (required for acceptance) or reference one already submitted