Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"standard" table organization #49

Closed
CDKnightNASA opened this issue Aug 13, 2020 · 1 comment · Fixed by #50 or #52
Closed

"standard" table organization #49

CDKnightNASA opened this issue Aug 13, 2020 · 1 comment · Fixed by #50 or #52
Assignees
Labels
bug Something isn't working
Milestone

Comments

@CDKnightNASA
Copy link
Contributor

Is your feature request related to a problem? Please describe.
sch_lab should use cFS standard table organization, to better facilitate per-target tables, etc. Right now, the table source is in fsw/src and the table header definition includes CI and TO header files which are only needed by the table.

Describe the solution you'd like

  1. Move the table source to fsw/tables
  2. Remove the #includes in sch_lab_sch_tab.h
  3. Rename sch_lab_sch_tab.h to sch_lab_table.h

Describe alternatives you've considered
none

Additional context
See https://github.com/nasa/sample_app for another example of how this would be structured.

Requester Info
Christopher.D.Knight@nasa.gov

@CDKnightNASA CDKnightNASA self-assigned this Aug 13, 2020
@jphickey
Copy link
Contributor

I like it as described, as long as we take care to avoid extra complexity/keep it simple. The point of the sch_lab app is just a quick and dirty way to get going in a debug environment. Folks who want complexity can use CFS SCH.

CDKnightNASA added a commit to CDKnightNASA/sch_lab that referenced this issue Aug 18, 2020
yammajamma pushed a commit that referenced this issue Aug 19, 2020
* fix #49, reorg schedule table to conform with std
@astrogeco astrogeco added the bug Something isn't working label Oct 1, 2020
@astrogeco astrogeco added this to the 2.5.0 milestone Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants