Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend using FcnCode (instead of CommandCode) terminology in the code #131

Open
2 tasks done
thnkslprpt opened this issue Oct 19, 2022 · 0 comments · May be fixed by #171
Open
2 tasks done

Recommend using FcnCode (instead of CommandCode) terminology in the code #131

thnkslprpt opened this issue Oct 19, 2022 · 0 comments · May be fixed by #171

Comments

@thnkslprpt
Copy link
Contributor

thnkslprpt commented Oct 19, 2022

Checklist

  • I reviewed the Contributing Guide.
  • I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Describe the bug
Copy of nasa/sample_app#167

Expected behavior
Rename the CommandCode variable in TO_LAB_exec_local_command() to FcnCode to better align with the cFE API.

Code snips

to_lab/fsw/src/to_lab_app.c

Lines 305 to 309 in 9e2ad8c

void TO_LAB_exec_local_command(CFE_SB_Buffer_t *SBBufPtr)
{
CFE_MSG_FcnCode_t CommandCode = 0;
CFE_MSG_GetFcnCode(&SBBufPtr->Msg, &CommandCode);

Reporter Info
Avi Weiss @thnkslprpt

thnkslprpt added a commit to thnkslprpt/to_lab that referenced this issue Oct 19, 2022
thnkslprpt added a commit to thnkslprpt/to_lab that referenced this issue Oct 20, 2022
thnkslprpt added a commit to thnkslprpt/to_lab that referenced this issue Nov 14, 2023
@thnkslprpt thnkslprpt linked a pull request Nov 14, 2023 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant