Remove All Packet command causes to_lab to break

[jhroach14]

Describe the bug
Sending the TO_REMOVE_ALL_PKT command to to_lab causes to_lab to unsubscribe from its own Message ID.
This means that to_lab will no longer respond to any commands and has to be restarted for it to function properly again. We ran into this problem at NASA Ames and figured that it was not intended behavior.

When testing for this bug be aware that it can be semi obscured by the fact that any commands for TO_LAB already on the Software Bus will still be processed by TO_Lab. This means that whether or not commands to TO_LAB sent after a TO_REMOVE_ALL_PKT command succeed is highly timing dependent.

To Reproduce
Steps to reproduce the behavior:

1. Send TO_REMOVE_PKT command to TO_LAB
2. Send any other command to TO_LAB
3. Observe that the command has no effect

Expected behavior
You should not be able to send TO_LAB a command that puts it into a non functional state

Code snips
//This line in to_lab_app.c line 543 is the source of the problem
status = CFE_SB_Unsubscribe(TO_LAB_CMD_MID, TO_LAB_Global.Cmd_pipe);

System observed on:
This bug is independent of the environment cfs is run in

Reporter Info
James Roach - NASA Research Scientist
james.h.roach@nasa.gov