Fix #135, Add version information to NOOP event #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thnkslprpt
force-pushed
the
fix-135-add-version-information-to-noop-event
branch
from
54a8227 to
bbe42b2
Compare
jphickey
approved these changes
Nov 1, 2023
jphickey
added
the
CCB:Ready
thnkslprpt
force-pushed
the
fix-135-add-version-information-to-noop-event
branch
3 times, most recently
from
3181539 to
e23416c
Compare
dzbaker
removed
the
CCB:Ready
|
Hi @thnkslprpt, would you be able to update this to make use of CFE_Config_GetVersionString() (see line 207 of to_lab_app.c for an example)? Thanks! |
thnkslprpt
force-pushed
the
fix-135-add-version-information-to-noop-event
branch
from
e23416c to
93342ef
Compare
thnkslprpt
force-pushed
the
fix-135-add-version-information-to-noop-event
branch
from
93342ef to
23a5728
Compare
@dzbaker That's updated now Dylan. |
Excellent, thanks! |
dzbaker
added a commit
that referenced
this pull request
Feb 23, 2024
…on-to-noop-event Fix #135, Add version information to NOOP event
This was referenced Feb 23, 2024
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Feb 23, 2024
*Combines:* cFE equuleus-rc1+dev96 osal equuleus-rc1+dev53 to_lab equuleus-rc1+dev44 **Includes:** *cFE* - nasa/cFE#2515 - nasa/cFE#2330 *osal* - nasa/osal#1448 - nasa/osal#1146 - nasa/osal#1357 - nasa/osal#1354 - nasa/osal#1331 *to_lab* - nasa/to_lab#191 - nasa/to_lab#136 Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com> Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com> Co-authored by: Sam Price <thesamprice@users.noreply.github.com>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Feb 23, 2024
*Combines:* cFE equuleus-rc1+dev96 osal equuleus-rc1+dev53 to_lab equuleus-rc1+dev44 **Includes:** *cFE* - nasa/cFE#2515 - nasa/cFE#2330 *osal* - nasa/osal#1448 - nasa/osal#1146 - nasa/osal#1357 - nasa/osal#1354 - nasa/osal#1331 *to_lab* - nasa/to_lab#191 - nasa/to_lab#136 Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com> Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com> Co-authored by: Sam Price <thesamprice@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
Testing performed
Run/Build and confirmed NOOP command event reporting as expected.
Expected behavior changes
Adds version information to NOOP command to align with the other cFS components/apps.
System(s) tested on
Intel(R) Celeron(R) N4100 CPU @ 1.10GHz x86_64
Debian GNU/Linux 11 (bullseye)
Contributor Info
Avi Weiss @thnkslprpt