to_lab Integration candidate: Caelum-rc4+dev64 #170
Conversation
Organize source files into a directory and naming pattern that is compliant with the CFE current recommended practice. Configurable items are moved to the respective header files and documentation is added to indicate what they do.
Add a separate "encode" step as part of TO_LAB output forwarding. Initially, this is just a pass through implementation, so it matches current behavior.
Fix #166, reorganize source files
…t-id-names Fix #133, Apply consistent Event ID names to common events
…l-if-elseif Fix #145, Refactor mutually exclusive logic in if, else if block
…ister-failure-during-init Fix #147, Add check for failure of CFE_EVS_Register() during initialization
…-codes-to-CFE_Status_t Fix #155, Convert int32 return codes and variables to CFE_Status_t
…ader-file Fix #157, Move function prototypes to header file
…ader-variable Fix #162, Update misnamed CmdHeader variable in to_lab_msg.h
Correct various merge issues in the latest IC
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -128,14 +94,16 @@ | |||
| /* TO_LAB_init() -- TO initialization */ | |||
| /* */ | |||
| /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ | |||
| int32 TO_LAB_init(void) | |||
| CFE_Status_t TO_LAB_init(void) | |||
Check notice
Code scanning / CodeQL-coding-standard
Long function without assertion Note
| @@ -128,14 +94,16 @@ | |||
| /* TO_LAB_init() -- TO initialization */ | |||
| /* */ | |||
| /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ | |||
| int32 TO_LAB_init(void) | |||
| CFE_Status_t TO_LAB_init(void) | |||
Check notice
Code scanning / CodeQL-coding-standard
Function too long Note
| } | ||
| } | ||
|
|
||
| void TO_LAB_TaskPipe(const CFE_SB_Buffer_t *SBBufPtr) |
Check notice
Code scanning / CodeQL-coding-standard
Long function without assertion Note
| /* TO_LAB_ProcessGroundCommand() -- Process local message */ | ||
| /* */ | ||
| /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ | ||
| void TO_LAB_ProcessGroundCommand(const CFE_SB_Buffer_t *SBBufPtr) |
Check notice
Code scanning / CodeQL-coding-standard
Long function without assertion Note
|
|
||
| /* initialize the packet data */ | ||
| TO_LAB_Global.DataTypesTlm.Payload.synch = 0x6969; | ||
| #if 0 |
Check notice
Code scanning / CodeQL-coding-standard
Conditional compilation Note
| /* TO_LAB_RemoveAll() -- Remove All Packets */ | ||
| /* */ | ||
| /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ | ||
| CFE_Status_t TO_LAB_RemoveAllCmd(const TO_LAB_RemoveAllCmd_t *data) |
Check notice
Code scanning / CodeQL-coding-standard
Long function without assertion Note
| /* TO_LAB_RemovePacket() -- Remove Packet */ | ||
| /* */ | ||
| /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ | ||
| CFE_Status_t TO_LAB_RemovePacketCmd(const TO_LAB_RemovePacketCmd_t *data) |
Check notice
Code scanning / CodeQL-coding-standard
Long function without assertion Note
| /* TO_LAB_AddPacket() -- Add packets */ | ||
| /* */ | ||
| /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ | ||
| CFE_Status_t TO_LAB_AddPacketCmd(const TO_LAB_AddPacketCmd_t *data) |
Check notice
Code scanning / CodeQL-coding-standard
Long function without assertion Note
| /* TO_LAB_SendDataTypes() -- Output data types */ | ||
| /* */ | ||
| /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ | ||
| CFE_Status_t TO_LAB_SendDataTypesCmd(const TO_LAB_SendDataTypesCmd_t *data) |
Check notice
Code scanning / CodeQL-coding-standard
Long function without assertion Note
| /* TO_LAB_EnableOutput() -- TLM output enabled */ | ||
| /* */ | ||
| /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ | ||
| CFE_Status_t TO_LAB_EnableOutputCmd(const TO_LAB_EnableOutputCmd_t *data) |
Check notice
Code scanning / CodeQL-coding-standard
Long function without assertion Note
Checklist (Please check before submitting)
Describe the contribution
CFE_EVS_Register()during initialization #148. Addresses Issue No notification of failure ofCFE_EVS_Register()inTO_LAB_init()#147int32return codes and variables toCFE_Status_t#156. Addresses Issue to_labint32return codes and variables should be converted toCFE_Status_t#155to_lab_app.c#157CmdHeadervariable into_lab_msg.h#163. Addresses Issue MisnamedCFE_MSG_CommandHeader_tvariable inTO_LAB_NoArgsCmd_t#162Testing performed
cFS Bundle Checks
to_lab Checks
Expected behavior changes
See PRs
System(s) tested on
Ubuntu 22.04
Additional context
Add any other context about the contribution here.
Third party code
If included, identify any third party code and provide text file of license
Contributor Info - All information REQUIRED for consideration of pull request
@thnkslprpt
@jphickey