Fix #175, define msgids via topicids #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The MsgID value is a conversion from TopicID
2 tasks
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Dec 12, 2023
*Combines:* to_lab v2.5.0-rc4+dev75 ci_lab v2.5.0-rc4+dev81 sample_app v1.3.0-rc4+dev69 sch_lab v2.5.0-rc4+dev75 cFE v7.0.0-rc4+dev434 osal v6.0.0-rc4+dev247 **Includes:** *to_lab* - nasa/to_lab#176 *ci_lab* - nasa/ci_lab#165 *sample_app* - nasa/sample_app#220 *sch_lab* - nasa/sch_lab#156 *cFE* - nasa/cFE#2472 - nasa/cFE#2411 - nasa/cFE#2474 *osal* - nasa/osal#1430 Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com> Co-authored by: Isaac Rowe <irowebbn@users.noreply.github.com> Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Dec 12, 2023
*Combines:* to_lab v2.5.0-rc4+dev75 ci_lab v2.5.0-rc4+dev81 sample_app v1.3.0-rc4+dev69 sch_lab v2.5.0-rc4+dev75 cFE v7.0.0-rc4+dev434 osal v6.0.0-rc4+dev247 **Includes:** *to_lab* - nasa/to_lab#176 *ci_lab* - nasa/ci_lab#165 *sample_app* - nasa/sample_app#220 *sch_lab* - nasa/sch_lab#156 *cFE* - nasa/cFE#2472 - nasa/cFE#2411 - nasa/cFE#2474 *osal* - nasa/osal#1430 Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com> Co-authored by: Isaac Rowe <irowebbn@users.noreply.github.com> Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Dec 12, 2023
*Combines:* to_lab v2.5.0-rc4+dev75 ci_lab v2.5.0-rc4+dev81 sample_app v1.3.0-rc4+dev69 sch_lab v2.5.0-rc4+dev75 cFE v7.0.0-rc4+dev434 osal v6.0.0-rc4+dev247 **Includes:** *to_lab* - nasa/to_lab#176 *ci_lab* - nasa/ci_lab#165 *sample_app* - nasa/sample_app#220 *sch_lab* - nasa/sch_lab#156 *cFE* - nasa/cFE#2472 - nasa/cFE#2411 - nasa/cFE#2474 *osal* - nasa/osal#1430 Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com> Co-authored by: Isaac Rowe <irowebbn@users.noreply.github.com> Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Dec 12, 2023
*Combines:* to_lab v2.5.0-rc4+dev75 ci_lab v2.5.0-rc4+dev81 sample_app v1.3.0-rc4+dev69 sch_lab v2.5.0-rc4+dev75 cFE v7.0.0-rc4+dev434 osal v6.0.0-rc4+dev247 **Includes:** *to_lab* - nasa/to_lab#176 *ci_lab* - nasa/ci_lab#165 *sample_app* - nasa/sample_app#220 *sch_lab* - nasa/sch_lab#156 *cFE* - nasa/cFE#2472 - nasa/cFE#2411 - nasa/cFE#2474 *osal* - nasa/osal#1430 Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com> Co-authored by: Isaac Rowe <irowebbn@users.noreply.github.com> Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
The MsgID value is a conversion from TopicID
Fixes #175
Testing performed
Build and run tests
Expected behavior changes
None, topic IDs were chosen such that the resulting MsgIDs are the same when using default config
System(s) tested on
Debian
Additional context
Depends on nasa/cFE#2474
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.