Fix #187, Zero-out global data during init + set RunStatus to APP_ERROR if init fails
#188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chillfig
added
enhancement
dzbaker
added
CCB:Approved
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Apr 16, 2024
*Combines:* cFE equuleus-rc1+dev131 to_lab equuleus-rc1+dev52 **Includes:** *cFE* - nasa/cFE#2548 *to_lab* - nasa/to_lab#188 Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com> Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
This was referenced Apr 16, 2024
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Apr 16, 2024
*Combines:* cFE equuleus-rc1+dev131 to_lab equuleus-rc1+dev52 **Includes:** *cFE* - nasa/cFE#2548 *to_lab* - nasa/to_lab#188 Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com> Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
RunStatustoCFE_ES_RunStatus_APP_ERRORif initialization fails #187RunStatustoCFE_ES_RunStatus_APP_ERRORif initialization fails rather than a simplereturn.memsetto zero-out the global data structure at the start of the initialization routineTesting performed
GitHub CI actions all passing successfully (incl. Build + Run, Unit/Functional Tests etc.).
Tested locally with cFS suite + Ground System tool to confirm start-up and commands still working as expected.
Expected behavior changes
CFE_ES_ExitApp()will now be called if initialization fails, rather than simply exiting out of the function with thereturnstatement.System(s) tested on
Debian GNU/Linux 11 (bullseye)
Current main branch of cFS bundle.
Contributor Info
Avi Weiss @thnkslprpt