Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #56, Add header guard to to_lab_sub_table.h #57

Merged
merged 1 commit into from
Aug 26, 2020

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Aug 21, 2020

Describe the contribution
Fix #56 - add header guard to to_lab_sub_table.h

Testing performed
Build and run - no issues

Expected behavior changes
No impact to behavior, good design practice

System(s) tested on

  • Hardware: cFS Dev Server
  • OS: Ubuntu 18.04
  • Versions: bundle main (+ cfe/osal main) + this change

Additional context
None

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added enhancement New feature or request CCB:FastTrack CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Aug 21, 2020
Copy link
Contributor

@astrogeco astrogeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a style guide for header guards? I wonder if we should use all caps.

@skliper
Copy link
Contributor Author

skliper commented Aug 26, 2020

GSFC 582 coding standard (C_Coding_Standard_20051129) recommendation says match file case.

@astrogeco
Copy link
Contributor

CCB 2020-08-26 - APPROVED, might want to open issues to standardize include guards across components

@astrogeco astrogeco removed the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Aug 26, 2020
@astrogeco astrogeco changed the base branch from main to integration-candidate August 26, 2020 22:00
@astrogeco astrogeco merged commit 51197e8 into nasa:integration-candidate Aug 26, 2020
@skliper skliper deleted the fix56-header-guard branch February 1, 2021 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:FastTrack enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LGTM warning - no header guard in to_lab_sub_table.h
4 participants