-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent Dumping and Loading Checkpoints During Run Mode #1727
Open
Mrockwell2
wants to merge
27
commits into
nasa:master
Choose a base branch
from
Mrockwell2:1461-edit-checkpoint-at-time
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oints-in-freeze-mode
Mrockwell2
changed the title
edit checkpoint at time
Prevent Dumping and Loading Checkpoints During Run Mode
May 31, 2024
Just found that this might break Master-Slave. The Slave can mimic the Master automatically when it dumps or loads a checkpoint. Going to have to look at how the Master dumps and loads checkpoints. I'm also going to create an issue that MasterSlave has no tests. |
- Also marked a section for a more detailed revision in a few days
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves issue #1461 while also allowing for scheduling checkpoints at future times and using trick.add_read to load checkpoints at specific times.