Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can destructure the require's load now #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kylegoetz
Copy link

I pulled the module's anonymous parser function into a named function and then referenced that inside the load function rather than using the $=this method. The latter breaks when you try

const {load} = require('rss-to-json')

but it works with the method I used. And since it's possible the user might only need to use load and never import parser or reader, I figured why not?

Also this varies in what it means depending on whether you're using strict mode or not (and if you use new by mistake), which just gives me the heebyjeebies :)

Because this technically changes the topology of the module by adding a new feature (but not breaking anything else), I bumped the version from 1.0.3 to 1.1.0 as per my understanding of semantic versioning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant