forked from sourcenetwork/defradb
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
refactor: Index field directive (sourcenetwork#2994)
## Relevant issue(s) Resolves sourcenetwork#2926 ## Description This PR fixes an issue where the index directive was defined twice. ~The `@index` field level directive has been renamed to `@indexField`.~ The `fields` arg has been renamed to `includes` and is now a list of objects of type: ``` type IndexFieldInput { name: String direction: Ordering } ``` The `direction` argument now sets the default direction of all fields in the `includes` list. When the index is used on a field definition and the field is not in the `includes` list it will be implicitly added. ## Tasks - [x] I made sure the code is well commented, particularly hard-to-understand areas. - [x] I made sure the repository-held documentation is changed accordingly. - [x] I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in [tools/configs/chglog/config.yml](tools/configs/chglog/config.yml)). - [x] I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ... ## How has this been tested? Covered by existing tests. Specify the platform(s) on which this was tested: - MacOS
- Loading branch information
Showing
13 changed files
with
502 additions
and
212 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.