Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong operator(should use / instead of *) on scaling factor, tested on Windows #90

Merged
merged 9 commits into from
Jan 16, 2024
Merged

Conversation

Originalimoc
Copy link
Contributor

No description provided.

add a fn to ignore scale_factor
Add a fn capture_area_ignore_area_check (for Windows only now)
std::cmp::min
@nashaofu
Copy link
Owner

The reason for this issue is here. I have already released a new version and it should have been fixed.
nashaofu/display-info@f80e78b#diff-ee9da70e8a36920d0c024abb7c25308cb435c3dcba46a3566abca2a11fd1cfffR119

display_info fixed
@Originalimoc
Copy link
Contributor Author

Okay reverted that change, remaining is still desirable to merge

Copy link
Owner

@nashaofu nashaofu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failed

@Originalimoc
Copy link
Contributor Author

I didn't use rustfmt, try again?

@nashaofu
Copy link
Owner

I didn't use rustfmt, try again?

If interested, you can participate in the development of the window screenshot function together #91

@nashaofu nashaofu merged commit 9234ce8 into nashaofu:master Jan 16, 2024
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants