feat(storage): default block size = 1024 (risingwavelabs#3463)

Signed-off-by: Alex Chi <iskyzh@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
nasnoisaac · Aug 9, 2022 · 90bc122 · 90bc122
1 parent dc06fa3
commit 90bc122
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/docker/risingwave.toml b/docker/risingwave.toml
@@ -9,7 +9,7 @@ checkpoint_interval_ms = 100
 [storage]
 shared_buffer_capacity_mb = 4096
 sstable_size_mb = 256
-block_size_kb = 64
+block_size_kb = 1024
 bloom_false_positive = 0.01
 data_directory = "hummock_001"
 block_cache_capacity_mb = 4096

diff --git a/src/bench/ss_bench/main.rs b/src/bench/ss_bench/main.rs
@@ -38,7 +38,7 @@ pub(crate) struct Opts {
     #[clap(long, default_value_t = 256)]
     table_size_mb: u32,
 
-    #[clap(long, default_value_t = 64)]
+    #[clap(long, default_value_t = 1024)]
     block_size_kb: u32,
 
     #[clap(long, default_value_t = 256)]

diff --git a/src/common/src/config.rs b/src/common/src/config.rs
@@ -220,7 +220,7 @@ mod default {
     }
 
     pub fn block_size_kb() -> u32 {
-        16
+        1024
     }
 
     pub fn bloom_false_positive() -> f64 {

diff --git a/src/config/risingwave.toml b/src/config/risingwave.toml
@@ -10,7 +10,7 @@ in_flight_barrier_nums = 40
 [storage]
 shared_buffer_capacity_mb = 4096
 sstable_size_mb = 256
-block_size_kb = 64
+block_size_kb = 1024
 bloom_false_positive = 0.01
 data_directory = "hummock_001"
 block_cache_capacity_mb = 4096
-Original file line number
+Diff line change
@@ Expand Up / @@ -220,7 +220,7 @@ mod default { @@
         }
         pub fn block_size_kb() -> u32 {
         }
         pub fn bloom_false_positive() -> f64 {
@@ Expand Down @@