SIGINT forwarding to a running subprocess #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the running task is something infinite, let's say a web server, we should be able to terminate it cleanly. To do that, we must forward the stop signal to the subprocess. Previously the signal was caught by Poe, which is not desirable.
|
Can't speak for the code, but I hope this gets merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the running task is something infinite, let's say a web server, we should
be able to terminate it cleanly. To do that, we must forward the stop signal
to the subprocess. Previously the signal was caught by Poe, which is not desirable.
This PR makes sure, that you can stop poe tasks by Ctrl+C. I run into it when runnning a web server. I got a poe stacktrace instead of my projects stacktrace. This should fix it. Hope you like it. 🙂