-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WB: RangeError invalid string length in invest stdErr callback #1092
Comments
I think I'll bundle the fix for this into #1089 On second thought, I think the solution here is actually to simplify the design of the UI and probably remove the component that is receiving this stderr data. The error message is already clearly displayed & highlighted in red in the log. So we'll fix this separately from #1089. |
It would also be nice to log these uncaught node exceptions. I think we can catch, log, and re-raise them with this listener https://nodejs.org/api/process.html#process_event_uncaughtexception |
A user reported this error. It shows up as an uncaught exception in the main electron process. The user's logs are filled with an excessive amount of stderr from
sdr
. The following is logged over and over:Since we are naively concatenating all invest stderr to a single string and then passing it to the browser when invest exits, we are apparently exceeding node's limit on string length nodejs/node#35973
Our stderr callback:
The text was updated successfully, but these errors were encountered: