Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Points over nodata aren't correctly identified by FID in scenic quality logging #1188

Closed
phargogh opened this issue Feb 18, 2023 · 0 comments · Fixed by #1190
Closed

Points over nodata aren't correctly identified by FID in scenic quality logging #1188

phargogh opened this issue Feb 18, 2023 · 0 comments · Fixed by #1190
Assignees
@phargogh
Labels
bug Something isn't working in progress This issue is actively being worked on

Comments

@phargogh
Copy link
Member

While working on a forums support request, I noticed this in the scenic quality logging:

2023-02-08 12:45:32,609 (natcap.invest.scenic_quality.scenic_quality) scenic_quality.execute(289) INFO Waiting for clipping to finish
2023-02-08 12:45:32,622 (natcap.invest.scenic_quality.scenic_quality) scenic_quality._determine_valid_viewpoints(460) INFO Layer structures_clipped has 2117 features
2023-02-08 12:45:32,808 (natcap.invest.scenic_quality.scenic_quality) scenic_quality._determine_valid_viewpoints(560) INFO Feature 2116 in layer structures_clipped is over nodata; skipping.
2023-02-08 12:45:32,817 (natcap.invest.scenic_quality.scenic_quality) scenic_quality._determine_valid_viewpoints(560) INFO Feature 2116 in layer structures_clipped is over nodata; skipping.
2023-02-08 12:45:32,817 (natcap.invest.scenic_quality.scenic_quality) scenic_quality._determine_valid_viewpoints(560) INFO Feature 2116 in layer structures_clipped is over nodata; skipping.
2023-02-08 12:45:32,818 (natcap.invest.scenic_quality.scenic_quality) scenic_quality._determine_valid_viewpoints(560) INFO Feature 2116 in layer structures_clipped is over nodata; skipping.
2023-02-08 12:45:32,819 (natcap.invest.scenic_quality.scenic_quality) scenic_quality._determine_valid_viewpoints(560) INFO Feature 2116 in layer structures_clipped is over nodata; skipping.
2023-02-08 12:45:32,819 (natcap.invest.scenic_quality.scenic_quality) scenic_quality._determine_valid_viewpoints(560) INFO Feature 2116 in layer structures_clipped is over nodata; skipping.
2023-02-08 12:45:32,819 (natcap.invest.scenic_quality.scenic_quality) scenic_quality._determine_valid_viewpoints(560) INFO Feature 2116 in layer structures_clipped is over nodata; skipping.
2023-02-08 12:45:32,819 (natcap.invest.scenic_quality.scenic_quality) scenic_quality._determine_valid_viewpoints(560) INFO Feature 2116 in layer structures_clipped is over nodata; skipping.
2023-02-08 12:45:32,820 (natcap.invest.scenic_quality.scenic_quality) scenic_quality._determine_valid_viewpoints(560) INFO Feature 2116 in layer structures_clipped is over nodata; skipping.

So there are 2117 features in the viewpoints vector, but a whole bunch of them (apparently feature 2116) is over nodata a whole lot. More likely, we're using the wrong ID here.
@phargogh phargogh added bug Something isn't working in progress This issue is actively being worked on labels Feb 18, 2023
@phargogh phargogh self-assigned this Feb 18, 2023
phargogh added a commit to phargogh/invest that referenced this issue Feb 18, 2023
@phargogh
Noting change in history. RE:natcap#1188
9349aa7
@phargogh phargogh mentioned this issue Feb 18, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phargogh phargogh

Labels
bug Something isn't working in progress This issue is actively being worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix scenic quality logging the incorrect FID when a point is over nodata phargogh/invest
1 participant
@phargogh