InVEST models don't validate input vector geometry

[dcdenu4]

There was a user who was getting odd results on the forums and it turns out they were passing in a watershed vector with a line geometry instead of a polygon.

Can we validate vector geometry type through the MODEL_SPEC?

[davemfish]

Offhand I know that CV does this validation for a few inputs, and it's somewhat verbose, so standardizing the approach sounds nice.

        vector = gdal.OpenEx(args['slr_vector_path'], gdal.OF_VECTOR)
        layer = vector.GetLayer()
        # all OGR point/multipoint codes
        if layer.GetGeomType() not in [
                ogr.wkbPoint, ogr.wkbMultiPoint,
                ogr.wkbPointM, ogr.wkbMultiPointM,
                ogr.wkbPointZM, ogr.wkbMultiPointZM,
                ogr.wkbPoint25D, ogr.wkbMultiPoint25D]:
            validation_warnings.append(
                (['slr_vector_path'], POINT_GEOMETRY_MSG))