-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code-signing certificate expired #1523
Comments
I have the certificates in hand and am working through the steps to update the certificate in our automation. |
Notes:
|
Until we can resolve this issue with UIT in a more centralized way (which I'm working on), ab794a2 comments out the Windows-specific code-signing stuff since our mac certificates are still valid for another year. |
OK, it turns out that Stanford doesn't offer GCP KMS, so unless they happen to provide some other alternative cloud-based HSM that doesn't cost an arm and a leg, I think the yubikeys may be our best approach. AWS does provide an HSM, but it's at a cost of over $1000/month (about $1.50 per minute), which is nuts in my opinion. So, the first step here will be to work out how to sign our windows binaries using the yubikey. Then, after that, it'd be neat to try out using a github actions self-hosted runner, especially w/r/t how to restrict access so that only approved code can run on the self-hosted runner. |
It turns out that there must be some kind of issue with my desktop computer (maybe just the age of hardware? Maybe the USBA-to-USBC adapter I'm using?) that is preventing Windows from being able to detect the installed key. I'm not sure what's up. When I run the same commands on my personal windows laptop, it works great following the docs at https://support.yubico.com/hc/en-us/articles/360016614840-Code-Signing-with-the-YubiKey-on-Windows NOTE: I did need to make sure that I set a different PUK on the key ... the default apparently will cause the key to be rejected by the smart card driver. |
We now are able to sign our binaries using a yubikey on our local computers, so this issue is effectively complete. To sign on Windows, I needed to:
The steps are described in the Yubico support docs here: https://support.yubico.com/hc/en-us/articles/360016614840-Code-Signing-with-the-YubiKey-on-Windows This key was the one used to generate the attestation, so I'm curious if we can copy the same certificate over to other yubikeys and then use them to sign the binaries. The signature would of course be different because each yubikey would have its own private key that we can't access, but that's fine ... we just want to be able to sign the binaries from multiple yubikeys. Future work: #1580 |
Our certificate expired on Jan 24th. Here's a failed workflow: https://github.com/natcap/invest/actions/runs/7849423200/job/21422745396
The text was updated successfully, but these errors were encountered: