Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forest Carbon test data: invalid geometries after reprojection #1689

Open
emlys opened this issue Nov 15, 2024 · 2 comments
Open

Forest Carbon test data: invalid geometries after reprojection #1689

emlys opened this issue Nov 15, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@emlys
Copy link
Member

emlys commented Nov 15, 2024

Enabling gdal.UseExceptions made this issue apparent. Two tests (test_carbon_dup_output and test_carbon_full) started failing because of invalid geometries in the vector resulting from reprojecting the original model data. For #1570 I'm going to just skip over any invalid geometries, since that's effectively what was happening before, but we should check why these are being produced and if there's any way to avoid it.

@emlys emlys added the bug Something isn't working label Nov 15, 2024
@davemfish
Copy link
Contributor

@emlys this sounds very familiar. Is it possible this was addressed here where James enabled parital reprojection, which I think skips over would-be invalid geometries? https://github.com/natcap/invest/pull/1646/files

@emlys
Copy link
Member Author

emlys commented Nov 18, 2024

@davemfish I confirmed I'm working on a branch that does have those changes, and the invalid geometries are not present before reprojection. Perhaps "partial reprojection" also means reprojecting just part of certain geometries (that are on the edge)? Just a guess

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants