Bugfix/1113 patch CVE-2007-4559 #1114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After thinking about it some more, datastack archives are a possible point of vulnerability for us because of the intended use of these archives: for folks to share data with us. So while the code might run in a trusted environment, we can't say the same about data. So I figured it might be worth going ahead with the patch anyways.
Originally reported in #1099 but declined for some good reasons.
Also, python should really still fix this upstream.
Fixes #1113
Checklist
- [ ] Updated the user's guide (if needed)- [ ] Tested the affected models' UIs (if relevant)