Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct sediment deposition progress logging #1292

Merged

Conversation

phargogh
Copy link
Member

@phargogh phargogh commented May 2, 2023

This PR fixes an issue with the sediment deposition progress logging where logging would progress non-linearly.

I don't have a test for this because it requires a reasonably large DEM to reproduce, which would really slow down our test suite.

Fixes #1262

Checklist

  • Updated HISTORY.rst and link to any relevant issue (if these changes are user-facing)
    - [ ] Updated the user's guide (if needed)
    - [ ] Tested the affected models' UIs (if relevant)

Copy link
Contributor

@davemfish davemfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Counting pixels by win_size definitely seems reliable!

@davemfish davemfish merged commit f4c4aca into natcap:main May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sediment deposition progress logging is incorrect
2 participants