Handle GDAL-land exceptions raised after upgrading pygeoprocessing #1646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phargogh
changed the title
phargogh
changed the title
…645-gdal-exceptions-in-validation Conflicts: requirements.txt
davemfish
approved these changes
Oct 15, 2024
| @@ -121,6 +121,25 @@ def capture_gdal_logging(): | |||
| gdal.PopErrorHandler() | |||
|
|
|||
|
|
|||
| @contextlib.contextmanager | |||
| def _set_gdal_configuration(opt, value): | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just adds support for GDAL's
RuntimeErrors in addition to pygeoprocessing'sValueErrors . I left both in, in case we have a case where we are supporting earlier versions of pygeoprocessing since it was trivial to support both versions of the exception.I also addressed an exception occurring in one of the tests because of a file name we changed recently.
Fixes #1645
Checklist
- [ ] Updated the user's guide (if needed)- [ ] Tested the Workbench UI (if relevant)