Stream plugin logging in real time #1659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@emlys , could you add a description to this please, if it's ready to review. I'm confusing the conversations we had about model logging vs. plugin installation logging. Thanks |
dcdenu4
approved these changes
Oct 24, 2024
| @@ -94,6 +94,7 @@ export function setupInvestRunHandlers() { | |||
| cmdArgs = [ | |||
| 'run', | |||
| `--prefix ${settingsStore.get(`plugins.${modelRunName}.env`)}`, | |||
| '--live-stream', | |||
There was a problem hiding this comment.
Cool, it looks like the mamba command was then capturing standard out/error without the --no-capture-output, --live-stream flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1654
This allows live logging from the plugin model run to be available to the workbench.
Checklist