Be able to compile with latest zig #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was about to fork the repo and make these changes on my own I see someone has already accomplished this. @natecraddock would love to see this merged! |
|
Hi! Thank you for these fixes, and sorry for the delay last week while I was taking a much needed break from things. I'll take a closer look at this after work, but at first glance it looks good! |
|
Thanks again for this, and sorry for the delay. Merged after making a tiny change to add in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi and thanks for this project!
This PR fixes a few build errors with the latest zig compiler that surfaced since ziglang/zig#18017 was merged.