Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes test suite for the breaking changes to node packages #11

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

kritzcreek
Copy link
Contributor

@kritzcreek kritzcreek commented Oct 9, 2023

I also added the npm files to install the compiler, spago and tidy. Happy to delete those if you'd rather not have them around.

(My main motivation was to maybe get this back into the package-set rotation)

@kritzcreek kritzcreek force-pushed the breaking-node-changes branch from 7feda0b to 8f0d617 Compare October 9, 2023 11:35
@kritzcreek kritzcreek force-pushed the breaking-node-changes branch from 8f0d617 to 6a39f3a Compare October 9, 2023 11:36
@kritzcreek
Copy link
Contributor Author

I can open kritzcreek#1 as a follow-up if you think switching to the next iteration of spago is a good idea yet. The main benefit imo is that we could split off the test dependencies from the library ones.

@natefaubion
Copy link
Owner

I would be OK with switching to spago@next.

@natefaubion natefaubion merged commit 5a40769 into natefaubion:master Oct 9, 2023
@kritzcreek kritzcreek deleted the breaking-node-changes branch October 31, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants