Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resubmit pull request... on request #35

Merged
merged 12 commits into from
Jun 20, 2012
Merged

Conversation

nickl-
Copy link
Contributor

@nickl- nickl- commented Jun 20, 2012

Resubmitted to dev branch as per #34

nickl- added 12 commits June 17, 2012 09:14
Allow running phpunit in tests folder alone.
Generate coverage report.
Headers should end in CRLF make them so.
So that diff may stap complaining about missing new lines.
Test changes made to Accept and User Agent headers.
Test changes made to hasErrors , raw_headers, _parseHeaders.
Additional tests against __toString and _parseCode in an attempt to get the coverage up.
Although not implicitly required added for completion.
Only status codes 4xx and 5xx should be considered errors. 1xx are informational and therefor not an error.
As per 2616 headers should end in CRLF parser should handle it appropriately.
Additional headers are optional and prser should consider not getting headers to parse.
Compose an User-Agent header by collecting available information.
This behaviour can be ommitted by adding a custom User-Agent request header.
If you can coneg against this Accept: header you can mark your implementation passed.
Contains all the legal LWS.
Preferable mime types are listed in reverse order, expected mime-type is added to the end.
The order the server should sort these in are as follows

1 expected/type
0.9 text/html;level=3
0.8 text/plain
0.5 *.*

This will also prevent you from getting 406 Not Acceptable errors.
Mainly done to be able to test against the composed header without a bajor refactor.
This is now similar to the response and although there are other ways to get this information from cURL this now makes HttpFul complete being able to provide both request and response headers.

Note the HTTP version is hard coded this might require additional work but should be efficient for the majority of use cases.
nategood pushed a commit that referenced this pull request Jun 20, 2012
Resubmit pull request... on request
@nategood nategood merged commit 63a1d20 into nategood:dev Jun 20, 2012
@nickl-
Copy link
Contributor Author

nickl- commented Jun 20, 2012

DAmn I just fixed the white space =/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants