#11 auto renew certificates #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Looks great! Thanks for picking this up. This is pretty much exactly how I was planning to do it but haven't had time to get around to it.
One minor nit-pick - I think there is an extra doc comment line that was accidentally merged in. Otherwise, the code looks great.
Thoughts on unit testing this? Obviously, we don't want to run tests for days or months, but I'd like to add some tests to this before releasing it to nuget. Doesn't have to hold up this PR, but maybe in a second step we can find a way to mock a system clock.
Co-authored-by: Nate McMaster <nate.mcmaster@gmail.com>
|
we need clock as a dependency for testing |
mbican
force-pushed
the
LE-11_Auto-renew_certificates
branch
from
b886c86 to
368703c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just couldn't wait and I rebased my #11 renewal implementation, maybe somebody will find it useful. Anyway the @natemcmaster implementation mbican@f601519 seems smarter so ¯_(ツ)_/¯