fix: show icon with gradients in Chrome #56
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that some icons (like
logos:vitejs
) are not showing in Chrome, but they work fine in Firefox.After some investigation, it seems that using
display: none
on the spritesheet's SVG causes gradients to don't work in Chrome. Resources:I also created a demo in CodePen to reproduce the issue (screenshot below):
This PR uses another technique to hide the spritesheet that should make everything work in Chrome.
For reference, here are my system's details: