Upgrade SVGO to v3 #76
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 547d523 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
rdwz
approved these changes
Jan 4, 2023
zoxon
approved these changes
Mar 18, 2023
|
Please merge :-) |
GrantBirki
approved these changes
Apr 28, 2023
|
I think this would be okay as a minor bump for the existing package code. The Are there any side-effects from updating to v3? |
Closed
1 task
|
Thanks for this PR! At this time we're going to forego this and focus on the v1 since this has a workaround and we have published a next version of |
a-game
added a commit
to a-game/a-game.github.io
that referenced
this pull request
Oct 7, 2023
# Note svgo 2.8.0 is not actually used by this repo, however it is used by astro-icon and the build fails unless it has that exact version [according to this](natemoo-re/astro-icon#76) Remove it once astro-icon is updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've gone through the changelog for SVGO v3, and tested my changes with a copy of the demo & an up-to-date Astro v1.8.0 project that used
astro-compresssvgo@3causes issues #65