New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 2-byte prefix with DNS message length in DoQ #53

Merged

natesales merged 1 commit into natesales:main from jaehnri:main

Jul 1, 2023

Contributor

jaehnri commented Jun 30, 2023 •

edited

Loading

Fixes #52

The reason it currently works is because the majority of DoQ servers support draft versions of RFC9250 that don't require this prefix, for example:
https://github.com/AdguardTeam/dnsproxy/blob/8497a8dcfd6859f3d71cf1352962d3c9adf6c923/proxy/server_quic.go#L178-L186

However, it is not compliant with the official RFC.

Thanks for q! :)


          Add 2-byte prefix with DNS message length in DoQ

d32c150

natesales merged commit 52f8563 into natesales:main

Owner

natesales commented Jul 1, 2023

Thanks for the fix! I've added a quic-no-length-prefix flag to revert to old behavior, making this the new default in compliance with RFC 9250.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet